Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Blacklist some session-specific variables #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunweaver
Copy link
Member

Things like XDG_SESSION_ID should not be uploaded to the environment.
For example this is broken currently:

  1. SSH to your machine
  2. Log in to MATE Shell
  3. Log out
  4. Log in again
  5. Lock the screen
  6. Try to unlock

You can't, and this is because the XDG_SESSION_ID from the first session
(step 2) has leaked through to the second one (step 4), and so MATE
Shell is listening to the logind UnlockSession signal for the wrong
session. The SSH session established in step 1 serves to keep the
systemd --user instance alive, so that the state is not torn down
between logins.

Original patch for GNOME by Iain Lane [email protected].

Patch ported over to MATE's session manager by Mike Gabriel
[email protected].

Fixes #271

Things like XDG_SESSION_ID should not be uploaded to the environment.
For example this is broken currently:

  1. SSH to your machine
  2. Log in to MATE Shell
  3. Log out
  4. Log in again
  5. Lock the screen
  6. Try to unlock

You can't, and this is because the XDG_SESSION_ID from the first session
(step 2) has leaked through to the second one (step 4), and so MATE
Shell is listening to the `logind` `UnlockSession` signal for the wrong
session. The SSH session established in step 1 serves to keep the
`systemd --user` instance alive, so that the state is not torn down
between logins.

Original patch for GNOME by Iain Lane <[email protected]>.

Patch ported over to MATE's session manager by Mike Gabriel
<[email protected]>.

Fixes mate-desktop#271
@sunweaver
Copy link
Member Author

@raveit65 This PR has a failing CI build. However, this does not look like a PR / patch problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't add XDG_SESSION_ID to dbus and systemd activation environment
1 participant