add task solution #1036
Open
add task solution #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarasHoliuk
suggested changes
Sep 23, 2024
src/components/TodoList/TodoList.tsx
Outdated
| }); | ||
| }; | ||
|
|
||
| const [visibleTodos, setVisibleTodos] = useState(todos); |
There was a problem hiding this comment.
So todos, query, and status are stored in state (redux state in this case). Taking it into account - the re-render will happen on any of these variables change. It means there is no reason to store visible todos in state - store them in common variable (and useMemo)
| </div> | ||
| </div> | ||
| ) : null} |
There was a problem hiding this comment.
use && instead of ternary in this case
|
It shouldn't be visible:
Check working version |
cant open an image |
anastasiiavorobiova
suggested changes
Sep 24, 2024
| </thead> | ||
|
|
||
| <tbody> | ||
| {visibleTodos.map(todo => ( |
There was a problem hiding this comment.
Consider using keys while rendering list
| data-cy="clearSearchButton" | ||
| type="button" | ||
| className="delete" | ||
| onClick={() => dispatch(setQuery(''))} |
There was a problem hiding this comment.
Suggested change
| onClick={() => dispatch(setQuery(''))} | |
| onClick={resetQuery} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO