Develop #1029
Open
Develop #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2024 17:17
GUSILLUS
suggested changes
Sep 17, 2024
Comment on lines
24
to
26
| <option value={Status.All}>All</option> | ||
| <option value={Status.Active}>Active</option> | ||
| <option value={Status.Completed}>Completed</option> |
There was a problem hiding this comment.
Consider using Object.values(your enum) and map() method
Comment on lines
38
to
40
| onChange={event => { | ||
| dispatch(filterActions.setQuery(event.target.value)); | ||
| }} |
|
|
||
| <td className="is-vcentered is-expanded"> | ||
| <p className={todo.completed ? 'has-text-success' : 'has-text-danger'}> | ||
| {todo.title} |
There was a problem hiding this comment.
Consider using destruction assignment for todo object
added 2 commits
September 17, 2024 17:50
etojeDenys
reviewed
Sep 17, 2024
|
|
||
| export const TodoFilter: React.FC = () => { | ||
| const dispatch = useDispatch<AppDispatch>(); | ||
| const query = useSelector((state: RootState) => state.filter.query); |
There was a problem hiding this comment.
do you know how to create useAppSelector and useAppDispatch hooks? better to use them and remove types everywhere
Suggested change
| const query = useSelector((state: RootState) => state.filter.query); | |
| const query = useAppSelector(state => state.filter.query); |
etojeDenys
approved these changes
Sep 17, 2024
added 2 commits
September 18, 2024 16:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK