Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1019

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ components (no need to write them in the store file)

## Instructions
- Install Prettier Extention and use this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_redux-list-of-todos/)
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://P-Nazar.github.io/react_redux-list-of-todos/)
- Follow the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline)
3,057 changes: 1,206 additions & 1,851 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"devDependencies": {
"@cypress/react18": "^2.0.1",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^1.9.12",
"@mate-academy/students-ts-config": "*",
"@mate-academy/stylelint-config": "*",
"@types/node": "^20.14.10",
Expand Down
81 changes: 64 additions & 17 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,26 +1,73 @@
import 'bulma/css/bulma.css';
import '@fortawesome/fontawesome-free/css/all.css';
import { Loader, TodoFilter, TodoList, TodoModal } from './components';
import { useEffect, useState } from 'react';
import { getTodos, getUser } from './api';
import { useDispatch, useSelector } from 'react-redux';
import { setTodos } from './features/todos';
import { CurrentTodo, Todo } from './types/Todo';
import { saveTodo } from './features/currentTodo';
import { RootState } from './app/store';

export const App = () => (
<>
<div className="section">
<div className="container">
<div className="box">
<h1 className="title">Todos:</h1>
export const App = () => {
const dispatch = useDispatch();
const [isLoading, setIsLoading] = useState(false);
const [isModalOpen, setIsModalOpen] = useState(false);

<div className="block">
<TodoFilter />
</div>
const currentTodo = useSelector<RootState, CurrentTodo | null>(
state => state.currentTodoSlice.currentTodo,
);

useEffect(() => {
setIsLoading(true);
getTodos()
.then(todos => {
dispatch(setTodos(todos));
})
.finally(() => {
setIsLoading(false);
});
}, []);

const openerModalWindow = async (userId: number, todo: Todo) => {
setIsModalOpen(true);

const user = await getUser(userId);

dispatch(
saveTodo({
...todo,
user,
}),
);

<div className="block">
<Loader />
<TodoList />
setTimeout(() => {
setIsModalOpen(false);
}, 300);
};

return (
<>
<div className="section">
<div className="container">
<div className="box">
<h1 className="title">Todos:</h1>

<div className="block">
<TodoFilter />
</div>

<div className="block">
{isLoading && <Loader />}

{!isLoading && <TodoList openerModalWindow={openerModalWindow} />}
</div>
</div>
</div>
</div>
</div>

<TodoModal />
</>
);
{currentTodo?.user && (
<TodoModal isModalOpen={isModalOpen} setIsModalOpen={setIsModalOpen} />
)}
</>
);
};
15 changes: 13 additions & 2 deletions src/app/store.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,21 @@
import { combineSlices, configureStore } from '@reduxjs/toolkit';
import filterReducer, { FilterStateSlice } from '../features/filter';
import todosReducer, { TodosState } from '../features/todos';
import currentTodoReducer, { CurrentTodoState } from '../features/currentTodo';

const rootReducer = combineSlices();
const rootReducer = combineSlices({
filterSlice: filterReducer,
todosSlice: todosReducer,
currentTodoSlice: currentTodoReducer,
});

export const store = configureStore({
reducer: rootReducer,
});

export type RootState = ReturnType<typeof rootReducer>;
export type RootState = {
filterSlice: FilterStateSlice;
todosSlice: TodosState;
currentTodoSlice: CurrentTodoState;
};
export type AppDispatch = typeof store.dispatch;
53 changes: 43 additions & 10 deletions src/components/TodoFilter/TodoFilter.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,42 @@
import React from 'react';
import React, { ChangeEvent } from 'react';
import { useDispatch, useSelector } from 'react-redux';
import { clearQuery, setQuery, setStatus } from '../../features/filter';
import { RootState } from '../../app/store';
import { Status } from '../../types/Status';

export const TodoFilter: React.FC = () => {
const dispatch = useDispatch();
const status = useSelector<RootState, Status>(
state => state.filterSlice.status,
);
const query = useSelector<RootState, string>(
state => state.filterSlice.query,
);

const handlerSelectChange = (e: ChangeEvent<HTMLSelectElement>) => {
dispatch(setStatus(e.target.value as Status));
};

const handlerInputChange = (e: ChangeEvent<HTMLInputElement>) => {
dispatch(setQuery(e.target.value as Status));
};

const clearInputChange = () => {
dispatch(clearQuery());
};

return (
<form
className="field has-addons"
onSubmit={event => event.preventDefault()}
>
<p className="control">
<span className="select">
<select data-cy="statusSelect">
<select
data-cy="statusSelect"
value={status}
onChange={handlerSelectChange}
>
<option value="all">All</option>
<option value="active">Active</option>
<option value="completed">Completed</option>
Expand All @@ -22,19 +50,24 @@ export const TodoFilter: React.FC = () => {
type="text"
className="input"
placeholder="Search..."
value={query}
onChange={handlerInputChange}
/>
<span className="icon is-left">
<i className="fas fa-magnifying-glass" />
</span>

<span className="icon is-right" style={{ pointerEvents: 'all' }}>
{/* eslint-disable-next-line jsx-a11y/control-has-associated-label */}
<button
data-cy="clearSearchButton"
type="button"
className="delete"
/>
</span>
{query.length > 0 && (
<span className="icon is-right" style={{ pointerEvents: 'all' }}>
{/* eslint-disable-next-line jsx-a11y/control-has-associated-label */}
<button
data-cy="clearSearchButton"
type="button"
className="delete"
onClick={clearInputChange}
/>
</span>
)}
</p>
</form>
);
Expand Down
Loading
Loading