add solution #1015
add solution #1015
Conversation
src/App.tsx
Outdated
| export const App = () => { | ||
| const [isLoading, setIsLoading] = useState(false); | ||
| const dispatch = useDispatch(); | ||
| const currentUser = useSelector((state: RootState) => state.currentTodo); |
There was a problem hiding this comment.
currentUser !== state.currentTodo
src/App.tsx
Outdated
| getTodos() | ||
| .then(todos => dispatch(setTodos(todos))) | ||
| .finally(() => setIsLoading(false)); | ||
| }, []); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array
src/App.tsx
Outdated
| <TodoModal /> | ||
| </> | ||
| ); | ||
| {currentUser && <TodoModal todo={currentUser} />} |
| getUser(todo.userId) | ||
| .then(userByTodo => setUser(userByTodo)) | ||
| .finally(() => setIsLoading(false)); | ||
| }, []); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'todo.userId'. Either include it or remove the dependency array
src/function/filterFunc.ts
Outdated
| case 'active': | ||
| return filtred.filter(todo => todo.completed === false); | ||
| case 'completed': | ||
| return filtred.filter(todo => todo.completed === true); | ||
| case 'all': |
src/App.tsx
Outdated
| {isLoading && <Loader />} | ||
| {!isLoading && <TodoList />} |
There was a problem hiding this comment.
Change syntax(In all such cases)
| {isLoading && <Loader />} | |
| {!isLoading && <TodoList />} | |
| { | |
| isLoading | |
| ? <Loader /> | |
| : <TodoList /> | |
| } |
| return ( | ||
| <form | ||
| className="field has-addons" | ||
| onSubmit={event => event.preventDefault()} | ||
| > | ||
| <p className="control"> | ||
| <span className="select"> | ||
| <select data-cy="statusSelect"> | ||
| <select data-cy="statusSelect" value={status} onChange={handleChange}> |
There was a problem hiding this comment.
if u have 3 or more attributes, move them to separate lines
| <select data-cy="statusSelect" value={status} onChange={handleChange}> | |
| <select | |
| data-cy="statusSelect" | |
| value={status} | |
| onChange={handleChange} | |
| > |
There was a problem hiding this comment.
I can't do this because if I display the information in three rows, after saving, it automatically returns to the blackberry row
| const handleQuery = (queryPayload: string) => { | ||
| dispatch(changeQuary(queryPayload)); | ||
| }; |
There was a problem hiding this comment.
this function receive event by default, change it
| const handleQuery = (queryPayload: string) => { | |
| dispatch(changeQuary(queryPayload)); | |
| }; | |
| const handleQuery = (e: ChangeEvent<HTMLInputElement>) => { | |
| dispatch(changeQuary(e.target.value)); | |
| }; |
src/components/TodoList/TodoList.tsx
Outdated
| </td> | ||
| </tr> | ||
| ))} | ||
| {/* | ||
| <tr data-cy="todo"> |
There was a problem hiding this comment.
remove all comments from project
| {isLoading && <Loader />} | ||
|
|
||
| <Loader /> | ||
| {!isLoading && ( |
There was a problem hiding this comment.
The same problem with syntax
isLoading ? (
<Loader />
) : (
......
)
DEMO LINK