Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #673

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ Vary: Accept
}
]
```


4. Return taken places for movie session details endpoint
```
Expand Down
7 changes: 7 additions & 0 deletions cinema/pagination.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from rest_framework.pagination import PageNumberPagination


class OrderPagination(PageNumberPagination):
page_size = 1
page_size_query_param = "page_size"
max_page_size = 100
47 changes: 44 additions & 3 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
from rest_framework import serializers

from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession
from django.db import transaction
from cinema.models import (
Genre,
Actor,
CinemaHall,
Movie,
MovieSession,
Order,
Ticket
)
Comment on lines +3 to +11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Style issue: It's recommended to group the imports using parentheses if needed. Consider organizing your imports in a more readable way. For example, you can group them by their purpose or their source.



class GenreSerializer(serializers.ModelSerializer):
Expand Down Expand Up @@ -59,6 +67,7 @@ class MovieSessionListSerializer(MovieSessionSerializer):
cinema_hall_capacity = serializers.IntegerField(
source="cinema_hall.capacity", read_only=True
)
tickets_available = serializers.IntegerField(read_only=True)

class Meta:
model = MovieSession
Expand All @@ -68,13 +77,45 @@ class Meta:
"movie_title",
"cinema_hall_name",
"cinema_hall_capacity",
"tickets_available"
)


class TicketSerializer(serializers.ModelSerializer):
class Meta:
model = Ticket
fields = "__all__"


class MovieSessionDetailSerializer(MovieSessionSerializer):
movie = MovieListSerializer(many=False, read_only=True)
cinema_hall = CinemaHallSerializer(many=False, read_only=True)
taken_places = TicketSerializer(source="tickets", many=True, read_only=True)

class Meta:
model = MovieSession
fields = ("id", "show_time", "movie", "cinema_hall")
fields = ("id", "show_time", "movie", "cinema_hall", "taken_places")


class TicketListSerializer(TicketSerializer):
movie_session = MovieSessionListSerializer(many=False, read_only=True)


class OrderSerializer(serializers.ModelSerializer):
tickets = TicketSerializer(many=True, read_only=False)

class Meta:
model = Order
fields = ("id", "user", "created_at", "tickets")

def create(self, validated_data):
with transaction.atomic():
tickets_data = validated_data.pop("tickets")
order = Order.objects.create(**validated_data)
for ticket_data in tickets_data:
Ticket.objects.create(order=order, **ticket_data)
return order


class OrderListSerializer(OrderSerializer):
tickets = TicketListSerializer(many=True, read_only=True)
2 changes: 2 additions & 0 deletions cinema/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
CinemaHallViewSet,
MovieViewSet,
MovieSessionViewSet,
OrderViewSet
)

router = routers.DefaultRouter()
Expand All @@ -15,6 +16,7 @@
router.register("cinema_halls", CinemaHallViewSet)
router.register("movies", MovieViewSet)
router.register("movie_sessions", MovieSessionViewSet)
router.register("orders", OrderViewSet)

urlpatterns = [path("", include(router.urls))]

Expand Down
85 changes: 82 additions & 3 deletions cinema/views.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
from rest_framework import viewsets

from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession

from django.db.models import F, Count
from cinema.models import (
Genre,
Actor,
CinemaHall,
Movie,
MovieSession,
Order,
Ticket
)
from cinema.serializers import (
GenreSerializer,
ActorSerializer,
Expand All @@ -12,8 +19,12 @@
MovieDetailSerializer,
MovieSessionDetailSerializer,
MovieListSerializer,
OrderSerializer,
OrderListSerializer
)

from cinema.pagination import OrderPagination


class GenreViewSet(viewsets.ModelViewSet):
queryset = Genre.objects.all()
Expand All @@ -34,6 +45,26 @@ class MovieViewSet(viewsets.ModelViewSet):
queryset = Movie.objects.all()
serializer_class = MovieSerializer

def get_queryset(self):
queryset = Movie.objects.all()
actors = self.request.query_params.get("actors")
genres = self.request.query_params.get("genres")
title = self.request.query_params.get("title")

if actors:
actors_ids = [int(str_id) for str_id in actors.split(",")]
queryset = queryset.filter(actors__id__in=actors_ids)
if genres:
genres_ids = [int(str_id) for str_id in genres.split(",")]
queryset = queryset.filter(genres__id__in=genres_ids)
if title:
queryset = queryset.filter(title__icontains=title)

if self.action in ["list", "retrieve"]:
queryset = queryset.prefetch_related("actors", "genres")

return queryset.distinct()

def get_serializer_class(self):
if self.action == "list":
return MovieListSerializer
Expand All @@ -48,6 +79,29 @@ class MovieSessionViewSet(viewsets.ModelViewSet):
queryset = MovieSession.objects.all()
serializer_class = MovieSessionSerializer

def get_queryset(self):
queryset = MovieSession.objects.all()
date = self.request.query_params.get("date")
movie_id = self.request.query_params.get("movie")
if date:
queryset = queryset.filter(show_time__date=date)
if movie_id:
queryset = queryset.filter(movie__id=int(movie_id))
if self.action == "list":
queryset = (
queryset.select_related("movie", "cinema_hall")
.annotate(
tickets_available=F(
"cinema_hall__rows"
) * F(
"cinema_hall__seats_in_row"
) - Count(
"tickets"
)
)
)
return queryset.distinct()

def get_serializer_class(self):
if self.action == "list":
return MovieSessionListSerializer
Expand All @@ -56,3 +110,28 @@ def get_serializer_class(self):
return MovieSessionDetailSerializer

return MovieSessionSerializer


class OrderViewSet(viewsets.ModelViewSet):
queryset = Order.objects.all()
serializer_class = OrderSerializer
pagination_class = OrderPagination

def get_queryset(self):
if self.request.user.is_authenticated:
queryset = self.queryset.filter(user=self.request.user)
if self.action == "list":
queryset = queryset.prefetch_related(
"tickets__movie_session__movie"
)
else:
queryset = self.queryset.none()
return queryset

def perform_create(self, serializer):
serializer.save(user=self.request.user)

def get_serializer_class(self):
if self.action == "list":
return OrderListSerializer
return OrderSerializer
4 changes: 4 additions & 0 deletions cinema_service/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,7 @@
# https://docs.djangoproject.com/en/4.0/ref/settings/#default-auto-field

DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"

REST_FRAMEWORK = {
"DEFAULT_PAGINATION_CLASS": "rest_framework.pagination.LimitOffsetPagination",
}
Binary file added db.sqlite3
Binary file not shown.
Loading