'Solution' #663
'Solution' #663
Conversation
| @@ -77,4 +87,52 @@ class MovieSessionDetailSerializer(MovieSessionSerializer): | |||
|
|
|||
| class Meta: | |||
| model = MovieSession | |||
| fields = ("id", "show_time", "movie", "cinema_hall") | |||
| fields = ("id", "show_time", "movie", "cinema_hall", "taken_places") | |||
There was a problem hiding this comment.
You added field taken_places, but model doesn't have this fields. You need to got it from tickets
cinema/serializers.py
Outdated
| @@ -68,6 +77,7 @@ class Meta: | |||
| "movie_title", | |||
| "cinema_hall_name", | |||
| "cinema_hall_capacity", | |||
| "tickets_available", | |||
There was a problem hiding this comment.
You need annotate method to your MovieSessionViewSet, to make this field available
cinema/views.py
Outdated
|
|
||
| from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession | ||
| from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession, Order |
There was a problem hiding this comment.
Spread imports on multiple lines
cinema/views.py
Outdated
| def get_queryset(self): | ||
| queryset = self.queryset.filter(user=self.request.user) | ||
| if self.action == "list": | ||
| queryset = queryset.prefetch_related("tickets__movie_session") |
There was a problem hiding this comment.
It would be better to prefetch_related("tickets__movie_session__movie", "tickets__movie_session__cinema_hall") instead of tickets__movie_session. Because there are indepent models which have relations with model MovieSession
cinema/serializers.py
Outdated
| class Meta: | ||
| model = Ticket | ||
| fields = [ | ||
| "id", | ||
| "order", | ||
| "row", | ||
| "seat", | ||
| "movie_session" | ||
| ] |
There was a problem hiding this comment.
We don't need order field in this serializer
| class TicketSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = Ticket | ||
| fields = ("id", "row", "seat", "movie_session") |
cinema/views.py
Outdated
| class OrderSetPagination(PageNumberPagination): | ||
| page_size = 1 | ||
| page_size_query_param = "page_size" | ||
| max_page_size = 3 |
There was a problem hiding this comment.
it would be better to create separated file for paginator. Do not mix ViewSets & Pagination in one class
| title = request.query_params.get("title") | ||
|
|
||
| if actors: | ||
| actor_ids = actors.split(",") |
There was a problem hiding this comment.
Would make sense to split and convert elements into int type - to be sure that you are being passed a valid numeric string + this should be placed in a separate method so you don't repeat yourself
| def clean(self): | ||
| @staticmethod | ||
| def ticket_validation( | ||
| row: int, |
| force_update=False, | ||
| using=None, | ||
| update_fields=None, | ||
| self, |
|
|
||
|
|
||
| class TicketPerformSerializer(serializers.ModelSerializer): | ||
| movie_session = serializers.PrimaryKeyRelatedField( |
There was a problem hiding this comment.
i think this serializer in unnecessary here - we are just passing an id of movie session on ticket create. You will need movie_session nested serializer when you display a list of Orders instead
| fields = ("id", "show_time", "movie", "cinema_hall", "taken_places") | ||
|
|
||
|
|
||
| class TicketSerializer(serializers.ModelSerializer): |
There was a problem hiding this comment.
you can inherit this from TicketPerformSerializer so you don't have to declare the same Meta class twice
|
|
||
| return order | ||
|
|
||
| def validate(self, attrs): |
There was a problem hiding this comment.
this validation logically belongs to Ticket serializer class
| if self.action == "list": | ||
| queryset = ( | ||
| queryset | ||
| .select_related("cinema_hall", "movie") |
There was a problem hiding this comment.
i guess here you will need to select_related for retrieve action as well
| return queryset | ||
|
|
||
|
|
||
| class OrderResultsSetPagination(PageNumberPagination): |
There was a problem hiding this comment.
would make sense to break down logic and put pagination in separate file
|
|
||
| def get_queryset(self): | ||
| query_set = self.queryset.select_related( | ||
| "user" |
There was a problem hiding this comment.
why prefetch user? are you accessing any of user's fields?
No description provided.