not solution, i need check because have a little problem with git #662
Conversation
cinema/serializers.py
Outdated
| @@ -35,6 +45,10 @@ class MovieListSerializer(MovieSerializer): | |||
| many=True, read_only=True, slug_field="full_name" | |||
| ) | |||
|
|
|||
| class Meta: | |||
| model = Movie | |||
| fields = MovieSerializer.Meta.fields + ("genres", "actors") | |||
There was a problem hiding this comment.
You inherit from MovieSerializer and it already has genres and actors fields in Meta
cinema/views.py
Outdated
| @@ -11,7 +15,7 @@ | |||
| MovieSessionListSerializer, | |||
| MovieDetailSerializer, | |||
| MovieSessionDetailSerializer, | |||
| MovieListSerializer, | |||
| MovieListSerializer, OrderSerializer, OrderListSerializer, | |||
There was a problem hiding this comment.
continue with each import on new line
cinema/views.py
Outdated
| return [int(num) for num in query.split(",")] | ||
|
|
||
| def get_queryset(self): | ||
| query_set = self.queryset |
cinema/views.py
Outdated
| @@ -56,3 +91,48 @@ def get_serializer_class(self): | |||
| return MovieSessionDetailSerializer | |||
|
|
|||
| return MovieSessionSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| query_set = ( | |||
There was a problem hiding this comment.
you already defined queryset with annotations above - just access it through self.
| return query_set | ||
|
|
||
|
|
||
| class OrderPagination(PageNumberPagination): |
There was a problem hiding this comment.
would be better structure to put pagination in a spearate file
| pagination_class = OrderPagination | ||
|
|
||
| def get_queryset(self): | ||
| return self.queryset.filter(user=self.request.user) |
|
|
||
| from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession | ||
| from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession, Order |
There was a problem hiding this comment.
If importing more than two items, it is better to write them on separate lines. This improves readability and maintenance of the code.
Example:
From taxi.models import (
Driver,
Manufacturer,
Car
)
Read more about topic here
| @@ -6,7 +6,7 @@ | |||
| ActorViewSet, | |||
| CinemaHallViewSet, | |||
| MovieViewSet, | |||
| MovieSessionViewSet, | |||
| MovieSessionViewSet, OrderViewSet, | |||
There was a problem hiding this comment.
Inconsistent. Just move to a new line.
| @@ -15,6 +15,7 @@ | |||
| router.register("cinema_halls", CinemaHallViewSet) | |||
| router.register("movies", MovieViewSet) | |||
| router.register("movie_sessions", MovieSessionViewSet) | |||
| router.register("orders", OrderViewSet) | |||
|
|
|||
| urlpatterns = [path("", include(router.urls))] | |||
There was a problem hiding this comment.
You could simplify it to urlpatterns = router.urls
if u see only one commit just reject it