Solution #659
Open
Solution #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maksym-Turenko
approved these changes
Oct 3, 2024
cinema/views.py
Outdated
| queryset = self.queryset.select_related("movie") | ||
|
|
||
| if self.action == "list": | ||
| queryset = ( |
There was a problem hiding this comment.
This is a bit of a weird hyphenation, I think it would be better to do it like this
queryset = queryset.annotate(
...
)
cinema/views.py
Outdated
| queryset = self.queryset.filter(user=self.request.user) | ||
|
|
||
| if self.action == "list": | ||
| queryset = ( |
There was a problem hiding this comment.
This is a bit of a weird hyphenation, I think it would be better to do it like this
queryset = queryset.prefetch_related(
...
)
oliasymak24
suggested changes
Oct 8, 2024
cinema/models.py
Outdated
Comment on lines
88
to
93
| def validate_row_and_seat( | ||
| row: int, | ||
| seat: int, | ||
| movie_session: MovieSession, | ||
| error_to_raise | ||
| ): |
There was a problem hiding this comment.
Annotations, everywhere :) they still exist)
cinema/serializers.py
Outdated
| order = Order.objects.create(**validated_data) | ||
| for ticket in tickets: | ||
| Ticket.objects.create(order=order, **ticket) | ||
| return order |
There was a problem hiding this comment.
In create/update/delete function you don't need to return anything
cinema/serializers.py
Outdated
|
|
||
|
|
||
| class TicketListSerializer(TicketSerializer): | ||
| movie_session = MovieSessionListSerializer(many=False, read_only=True) |
cinema/views.py
Outdated
| @@ -43,11 +63,35 @@ def get_serializer_class(self): | |||
|
|
|||
| return MovieSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = self.queryset | |||
cinema/views.py
Outdated
Comment on lines
132
to
135
| class OrderSetPagination(PageNumberPagination): | ||
| page_size = 2 | ||
| page_size_query_param = "page_size" | ||
| max_page_size = 20 |
There was a problem hiding this comment.
Put pagination better in separate file
Nattalli
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.