Solution #878
Open
Solution #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oleksl888
suggested changes
Sep 3, 2024
services/movie.py
Outdated
| from django.db.models import QuerySet | ||
|
|
||
| from db.models import Movie | ||
|
|
||
|
|
||
| def get_movies( | ||
| genres_ids: list[int] = None, | ||
| actors_ids: list[int] = None, | ||
| genres_ids: Optional[list[int]] = None, |
services/movie.py
Outdated
| movie_description: str, | ||
| genres_ids: list = None, | ||
| actors_ids: list = None, | ||
| movie_title: str, |
services/movie_session.py
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
|
|
|||
| def create_movie_session( | |||
| movie_show_time: str, movie_id: int, cinema_hall_id: int | |||
| movie_show_time: str, movie_id: int, cinema_hall_id: int | |||
There was a problem hiding this comment.
you should pay attention when you use tools for formatting code now indentation is broken everywhere
services/movie_session.py
Outdated
| @@ -24,11 +24,19 @@ def get_movie_session_by_id(movie_session_id: int) -> MovieSession: | |||
| return MovieSession.objects.get(id=movie_session_id) | |||
|
|
|||
|
|
|||
| def get_taken_seats(movie_session_id: int) -> list[dict]: | |||
| tickets = MovieSession.objects.get(id=movie_session_id).tickets.all() | |||
services/movie_session.py
Outdated
| show_time: str = None, | ||
| movie_id: int = None, | ||
| cinema_hall_id: int = None, | ||
| session_id: int, |
services/user.py
Outdated
|
|
||
|
|
||
| def get_user(user_id: int) -> get_user_model(): | ||
| return get_user_model().objects.get(id=user_id) |
services/user.py
Outdated
| first_name: Optional[str] = None, | ||
| last_name: Optional[str] = None | ||
| ) -> None: | ||
| user = get_user_model().objects.get(id=user_id) |
There was a problem hiding this comment.
you can reuse your get_user here to keep it DRY
MNDonut
suggested changes
Sep 6, 2024
db/models.py
Outdated
| from django.db import models | ||
| from django.db.models import UniqueConstraint | ||
|
|
||
| import settings |
There was a problem hiding this comment.
use from django.conf import settings to use real global settings because you may have multiple settings files or folders with this name
services/movie_session.py
Outdated
Comment on lines
27
to
34
| def get_taken_seats(movie_session_id: int) -> list[dict]: | ||
| tickets = MovieSession.objects.get( | ||
| id=movie_session_id | ||
| ).tickets.values("row", "seat") | ||
| return [ | ||
| {"row": ticket["row"], "seat": ticket["seat"]} | ||
| for ticket in tickets | ||
| ] |
There was a problem hiding this comment.
you actually do the same job twice using .values() and creating a list of dicts.
.values() returns queryset of dicts. you can use this fact
services/movie_session.py
Outdated
| for ticket in tickets | ||
| ] | ||
|
|
||
|
|
||
| def update_movie_session( | ||
| session_id: int, | ||
| show_time: str = None, |
services/order.py
Outdated
Comment on lines
25
to
28
| Ticket( | ||
| movie_session=MovieSession.objects.get( | ||
| id=ticket["movie_session"] | ||
| ), |
There was a problem hiding this comment.
set movie_session_id as you get id instead of fetching that object
Oleksl888
reviewed
Sep 16, 2024
| @@ -24,11 +26,19 @@ def get_movie_session_by_id(movie_session_id: int) -> MovieSession: | |||
| return MovieSession.objects.get(id=movie_session_id) | |||
|
|
|||
|
|
|||
| def get_taken_seats(movie_session_id: int) -> list[dict]: | |||
| return list( | |||
| MovieSession.objects.get( | |||
There was a problem hiding this comment.
here you could reuse get_movie_session_by_id function defined above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.