Solution #875
Open
Solution #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNDonut
suggested changes
Sep 3, 2024
db/models.py
Outdated
| f"(1, {self.movie_session.cinema_hall.seats_in_row})" | ||
| }) | ||
|
|
||
| def save(self, *args, **kwargs) -> Callable: |
There was a problem hiding this comment.
It's None actually, save doesn't return anything
services/movie.py
Outdated
| @@ -6,6 +7,7 @@ | |||
| def get_movies( | |||
| genres_ids: list[int] = None, | |||
| actors_ids: list[int] = None, | |||
| title: str = None | |||
services/movie_session.py
Outdated
Comment on lines
52
to
53
| Ticket.objects | ||
| .filter(movie_session_id=movie_session_id) |
There was a problem hiding this comment.
Or reuse get_movie_session_by_id and use related_name to fetch tickets of this movie session. But this is ok as well
services/order.py
Outdated
| def create_order( | ||
| tickets: list[dict], | ||
| username: str, | ||
| date: datetime = None |
There was a problem hiding this comment.
datetime or None. Fix evewhere annotation
services/order.py
Outdated
| date: datetime = None | ||
| ) -> Order: | ||
| with transaction.atomic(): | ||
| order = Order.objects.create(user=User.objects.get(username=username)) |
There was a problem hiding this comment.
Use get_user_model instead of using User explicitly because the purpose of AUTH_USER_MODEL is to not hardcode main model
services/order.py
Outdated
| return order | ||
|
|
||
|
|
||
| def get_orders(username: str = None) -> QuerySet: |
| for ticket in tickets | ||
| ] | ||
|
|
||
| Ticket.objects.bulk_create(new_tickets) |
services/user.py
Outdated
Comment on lines
10
to
12
| email: str = None, | ||
| first_name: str = None, | ||
| last_name: str = None |
| @@ -0,0 +1,65 @@ | |||
| from __future__ import annotations | |||
| from django.contrib.auth import get_user_model | |||
There was a problem hiding this comment.
But here you use get_user_model, isn't it strange? 👀
There was a problem hiding this comment.
Yes, that's because I had python 3.9. Now I have updated it)
services/user.py
Outdated
Comment on lines
38
to
42
| username: str = None, | ||
| password: str = None, | ||
| email: str = None, | ||
| first_name: str = None, | ||
| last_name: str = None, |
MNDonut
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.