Solution #871
Open
Solution #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et(override clean and save methods for data validation), User; update already existing services & create services order and user
…et(override clean and save methods for data validation), User; update already existing services & create services order and user
# Conflicts: # services/order.py
MNDonut
suggested changes
Sep 3, 2024
db/models.py
Outdated
| from django.db import models | ||
|
|
||
| import settings |
There was a problem hiding this comment.
it's better to use
from django.conf import settings because you may want to have settings folder and python will import it instead of real settings
db/models.py
Outdated
Comment on lines
9
to
12
| name = models.CharField( | ||
| max_length=255, | ||
| unique=True | ||
| ) |
There was a problem hiding this comment.
no need to move it if it fits in one line in lest than 79 characters
services/movie.py
Outdated
Comment on lines
9
to
12
| def get_movies( | ||
| genres_ids: list[int] = None, | ||
| actors_ids: list[int] = None, | ||
| genres_ids: Optional[list[int]] = None, | ||
| actors_ids: Optional[list[int]] = None, | ||
| title: Optional[str] = None, |
There was a problem hiding this comment.
let's use | operator everywhere instead of Optional because it's an old approach
services/movie_session.py
Outdated
| @@ -13,7 +17,7 @@ def create_movie_session( | |||
| ) | |||
|
|
|||
|
|
|||
| def get_movies_sessions(session_date: str = None) -> QuerySet: | |||
| def get_movies_sessions(session_date: Optional[str] = None) -> QuerySet: | |||
There was a problem hiding this comment.
Specify what kind of objects this queyset contains
…cify kind of objects which returned QuerySet contains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.