Solution #855
Open
Solution #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNDonut
suggested changes
Aug 31, 2024
db/models.py
Outdated
| from django.db import models | ||
|
|
||
| import settings |
There was a problem hiding this comment.
it's better to use
from django.conf import settings because there may be a few settings or a folder named "settings"
services/movie.py
Outdated
| @@ -6,6 +7,7 @@ | |||
| def get_movies( | |||
| genres_ids: list[int] = None, | |||
| actors_ids: list[int] = None, | |||
| title: str = None, | |||
There was a problem hiding this comment.
str or None. fix annotation everywhere
services/movie_session.py
Outdated
Comment on lines
50
to
51
| {"row": ticket.row, "seat": ticket.seat} | ||
| for ticket in movie_session.tickets.all() |
There was a problem hiding this comment.
you can use .values() method instead of creating dicts manually
oliasymak24
suggested changes
Aug 31, 2024
services/user.py
Outdated
| first_name: str = "", | ||
| last_name: str = "", | ||
| ) -> User: | ||
| return get_user_model().objects.create_user( |
There was a problem hiding this comment.
You don’t need to return anything in create/update/delete methods, check everywhere
MNDonut
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.