Solution #850
Open
Solution #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiudmylaKulinchenko
suggested changes
Aug 28, 2024
services/movie_session.py
Outdated
Comment on lines
48
to
49
| session = MovieSession.objects.get(id=movie_session_id) | ||
| taken_seats = session.ticket_set.values("row", "seat") |
There was a problem hiding this comment.
You can make it in one request: filter tickets by movie_session_id
services/order.py
Outdated
| date: str = None, | ||
| ) -> None: | ||
|
|
||
| the_user = get_user_model().objects.get(username=username) |
There was a problem hiding this comment.
The prefix the_ is not necessary. Simply using user would be more conventional and clear
There was a problem hiding this comment.
if you want to make it more clear, you can use order_date instead of date
services/order.py
Outdated
|
|
||
| the_user = get_user_model().objects.get(username=username) | ||
| with transaction.atomic(): | ||
| the_order = Order.objects.create( |
oliasymak24
suggested changes
Aug 29, 2024
settings.py
Outdated
There was a problem hiding this comment.
You don't need to commit this, add to .gitignor
db/models.py
Outdated
|
|
||
| class Order(models.Model): | ||
| created_at = models.DateTimeField(auto_now_add=True) | ||
| user = models.ForeignKey(to=User, on_delete=models.CASCADE) |
There was a problem hiding this comment.
you should refer to AUTH_USER_MODEL
services/user.py
Outdated
| if last_name: | ||
| user_to_update.last_name = last_name | ||
|
|
||
| user_to_update.save() |
oliasymak24
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.