"Solution" #849
Open
"Solution" #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNDonut
suggested changes
Aug 31, 2024
db/models.py
Outdated
| from django.db import models | ||
| from django.db.models import UniqueConstraint | ||
|
|
||
| import settings |
There was a problem hiding this comment.
it's better to use
from django.conf import settings because you may have a few settings files or a folder named "settings". This import searches for real settings
services/movie.py
Outdated
Comment on lines
8
to
10
| genres_ids: list[int] = None, | ||
| actors_ids: list[int] = None, | ||
| title: str = None, |
There was a problem hiding this comment.
list/str or None type. Fix annotation everywhere
services/movie.py
Outdated
| @@ -15,13 +17,17 @@ def get_movies( | |||
| if actors_ids: | |||
| queryset = queryset.filter(actors__id__in=actors_ids) | |||
|
|
|||
| if title: | |||
| queryset = queryset.filter(title__contains=title) | |||
There was a problem hiding this comment.
I recommend to use "icontains" because when you look for the movie "The Maze Runner" and enter "maze" it should find the movie as well(for user's comfortability)
So:
contains - case-sensitive (when Maze and maze are different words)
icontains - case-insensitive (when both Maze and maze are the same)
oliasymak24
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.