Implemented solution #839
Open
Implemented solution #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNDonut
suggested changes
Aug 30, 2024
db/models.py
Outdated
| from django.db import models | ||
|
|
||
| import settings |
There was a problem hiding this comment.
it's better to use
from django.conf import settings because it defines correct settings(as there may be a folder named settings)
db/models.py
Outdated
| @@ -17,14 +23,19 @@ def __str__(self) -> str: | |||
|
|
|||
|
|
|||
| class Movie(models.Model): | |||
| title = models.CharField(max_length=255) | |||
| title = models.CharField(max_length=255, db_index=True) | |||
There was a problem hiding this comment.
either db_index = True or indexes should be used. indexes are often used for complex indexes
|
|
||
|
|
||
| class Order(models.Model): | ||
| created_at = models.DateTimeField(default=datetime.datetime.now) |
There was a problem hiding this comment.
I tried but It did not work due to mocking datetime. And It would be too strange to override save methods just to pass all the tests
db/models.py
Outdated
| class Order(models.Model): | ||
| created_at = models.DateTimeField(default=datetime.datetime.now) | ||
| user = models.ForeignKey( | ||
| settings.AUTH_USER_MODEL, on_delete=models.CASCADE, |
There was a problem hiding this comment.
we don't add multiple parameters on the same line
services/movie.py
Outdated
| @@ -6,6 +7,7 @@ | |||
| def get_movies( | |||
| genres_ids: list[int] = None, | |||
| actors_ids: list[int] = None, | |||
| title: str = None, | |||
services/order.py
Outdated
| def create_order( | ||
| tickets: list[dict], | ||
| username: str, | ||
| date: str = None |
services/order.py
Outdated
| Ticket.objects.bulk_create(raw_tickets) | ||
|
|
||
|
|
||
| def get_orders(username: str = None) -> QuerySet: |
services/user.py
Outdated
| def create_user( | ||
| username: str, | ||
| password: str, | ||
| email: str = None, |
services/user.py
Outdated
Comment on lines
28
to
32
| username: str = None, | ||
| password: str = None, | ||
| email: str = None, | ||
| first_name: str = None, | ||
| last_name: str = None |
MNDonut
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.