solution #512
Open
solution #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrykivd
approved these changes
Nov 8, 2023
db/models.py
Outdated
Comment on lines
94
to
102
| if not (1 < self.seat < self.movie_session.cinema_hall.seats_in_row): | ||
| raise ValidationError( | ||
| { | ||
| "seat": [f"seat number must be in available range: " | ||
| f"(1, seats_in_row): " | ||
| f"(1, " | ||
| f"{self.movie_session.cinema_hall.seats_in_row})"] | ||
| } | ||
| ) |
There was a problem hiding this comment.
You can use a variable "valid_row/seat", it's improve readability of your code.
Comment on lines
+74
to
+75
| class Meta: | ||
| ordering = ["-created_at"] |
There was a problem hiding this comment.
class Meta should be placed before methods, don't forget to read checklist, please
LiudmylaKulinchenko
suggested changes
Nov 9, 2023
Comment on lines
+74
to
+75
| class Meta: | ||
| ordering = ["-created_at"] |
fsocie7y
suggested changes
Nov 15, 2023
services/user.py
Outdated
Comment on lines
11
to
29
| user = User.objects.create_user( | ||
| username=username, | ||
| password=password | ||
| ) | ||
|
|
||
| if email: | ||
| user.email = email | ||
|
|
||
| if first_name: | ||
| user.first_name = first_name | ||
|
|
||
| if last_name: | ||
| user.last_name = last_name | ||
|
|
||
| user.save() | ||
|
|
||
|
|
||
| def get_user(user_id: int) -> User: | ||
| return User.objects.get(id=user_id) |
db/models.py
Outdated
|
|
||
| class Order(models.Model): | ||
| created_at = models.DateTimeField(auto_now_add=True) | ||
| user = models.ForeignKey(to=User, on_delete=models.CASCADE) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.