implemented tickets-and-orders #391
Conversation
db/models.py
Outdated
| @@ -17,7 +18,7 @@ def __str__(self) -> str: | |||
|
|
|||
|
|
|||
| class Movie(models.Model): | |||
| title = models.CharField(max_length=255) | |||
| title = models.CharField(max_length=255, db_index=True) | |||
There was a problem hiding this comment.
I think its bad practice when you use db_index=True. Because when the model expands it will be difficult to maintain
| def __str__(self) -> str: | ||
| return f"{self.created_at}" | ||
|
|
||
| class Meta: |
There was a problem hiding this comment.
class meta should be after attribute and before methods
db/models.py
Outdated
| ) | ||
|
|
||
| def clean(self) -> None: | ||
| from django.core.exceptions import ValidationError |
There was a problem hiding this comment.
bad practice I think mentors reject if u will use import like this
db/models.py
Outdated
| def clean(self) -> None: | ||
| from django.core.exceptions import ValidationError | ||
|
|
||
| if not 1 <= self.row <= self.movie_session.cinema_hall.rows: |
There was a problem hiding this comment.
if not (1 <= self.row <= self.movie_session.cinema_hall.rows):
db/models.py
Outdated
| ] | ||
| } | ||
| ) | ||
| if not 1 <= self.seat <= self.movie_session.cinema_hall.seats_in_row: |
| return queryset | ||
|
|
||
|
|
||
| def get_movie_by_id(movie_id: int) -> Movie: | ||
| return Movie.objects.get(id=movie_id) | ||
|
|
||
|
|
||
| @atomic |
There was a problem hiding this comment.
probably better use transtaction.atomic() but not sure. Mb mentors can help with this)
There was a problem hiding this comment.
yeah, it is more usual to use @transaction.atomic decorator,but it think this is not critical
db/models.py
Outdated
|
|
||
| class Order(models.Model): | ||
| created_at = models.DateTimeField(auto_now_add=True) | ||
| user = models.ForeignKey(to=User, on_delete=models.CASCADE) |
| @@ -42,3 +44,11 @@ def update_movie_session( | |||
|
|
|||
| def delete_movie_session_by_id(session_id: int) -> None: | |||
| MovieSession.objects.get(id=session_id).delete() | |||
|
|
|||
|
|
|||
| def get_taken_seats(movie_session_id: int) -> List[dict]: | |||
There was a problem hiding this comment.
I think bad formatting but not sure
| from settings import AUTH_USER_MODEL | ||
|
|
||
|
|
||
| def create_user( |
There was a problem hiding this comment.
u can use here kwargs and check if key in ["first_name".....] - Oleg hint
services/user.py
Outdated
|
|
||
|
|
||
| def get_user(user_id: int) -> AUTH_USER_MODEL: | ||
| user = get_user_model() |
There was a problem hiding this comment.
optional, but zero sense to create variable
| return user.objects.get(id=user_id) | ||
|
|
||
|
|
||
| def update_user( |
db/models.py
Outdated
|
|
||
| class Order(models.Model): | ||
| created_at = models.DateTimeField(auto_now_add=True) | ||
| user = models.ForeignKey(to=User, on_delete=models.CASCADE) |
db/models.py
Outdated
| @@ -17,7 +18,7 @@ def __str__(self) -> str: | |||
|
|
|||
|
|
|||
| class Movie(models.Model): | |||
| title = models.CharField(max_length=255) | |||
| title = models.CharField(max_length=255, db_index=True) | |||
| description = models.TextField() | |||
| actors = models.ManyToManyField(to=Actor) | |||
| from settings import AUTH_USER_MODEL | ||
|
|
||
|
|
||
| def create_user( |
| return queryset | ||
|
|
||
|
|
||
| def get_movie_by_id(movie_id: int) -> Movie: | ||
| return Movie.objects.get(id=movie_id) | ||
|
|
||
|
|
||
| @atomic |
There was a problem hiding this comment.
yeah, it is more usual to use @transaction.atomic decorator,but it think this is not critical
No description provided.