Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 3 classes of delivery robots #575

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KristianYe
Copy link

No description provided.

@ORENYT
Copy link

ORENYT commented Aug 11, 2023

I would recommend to use this formatting because mentor rejects codes with another formating

Copy link

@ORENYT ORENYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrong formatting

app/main.py Outdated
def __init__(self,
name: str,
weight: str,
coords: list = None) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you to change formatting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

app/main.py Outdated
def __init__(self,
name: str,
weight: str,
coords: list = None) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

app/main.py Outdated
weight: str,
max_load_weight: int,
coords: list = None,
current_load: bool | Cargo = None) -> None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

app/main.py Outdated
def __init__(self,
name: str,
weight: str,
coords: list = None) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

app/main.py Outdated
weight: str,
max_load_weight: int,
coords: list = None,
current_load: bool | Cargo = None,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why bool?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My inattention

Copy link

@Kroll410 Kroll410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants