Solution #557
Open
Solution #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Jul 25, 2023
app/main.py
Outdated
Comment on lines
10
to
12
| self.coords = coords | ||
| if coords is None: | ||
| self.coords = [0, 0] |
There was a problem hiding this comment.
Avoid such construction of assigning an attribute and instantly redefining it. You could use the conditional variable assignment or or expression.
app/main.py
Outdated
Comment on lines
32
to
34
| super().__init__(name, weight, coords) | ||
| if coords is None: | ||
| self.coords = [0, 0, 0] |
There was a problem hiding this comment.
Pass the correct coords value directly in the __init__, do not redefine it after initialization.
app/main.py
Outdated
Comment on lines
55
to
56
| if coords is None: | ||
| self.coords = [0, 0, 0] |
There was a problem hiding this comment.
Pass the correct coords value directly in the __init__, do not redefine it after initialization.
app/main.py
Outdated
| # write your code here | ||
|
|
||
| class BaseRobot: | ||
| def __init__(self, name: str, weight: int, coords: list = None) -> None: |
There was a problem hiding this comment.
You could be more specific in type hinting, stating that you expect a list of integers as an input to the coords here and in the other places as well.
Polyakiv-Andrey
suggested changes
Jul 27, 2023
app/main.py
Outdated
| ) -> None: | ||
| self.name = name | ||
| self.weight = weight | ||
| self.coords = coords or [0, 0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.