solution #555
Open
solution #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
approved these changes
Jul 21, 2023
| def __init__(self, name: str, weight: int, coords: list = None) -> None: | ||
| self.name = name | ||
| self.weight = weight | ||
| self.coords = coords if coords is not None else [0, 0] |
There was a problem hiding this comment.
Instead of using conditional variable assignment, you could consider using the or expression here. It would be more laconic and does not require using None. Read more about this here.
|
|
||
|
|
||
| class FlyingRobot(BaseRobot): | ||
| def __init__(self, name: str, weight: int, coords: list = None) -> None: |
There was a problem hiding this comment.
You could expand type hinting here more, declaring that you expect to get the list of three integers for coords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.