solution_ver-1 #1266
solution_ver-1 #1266
Conversation
There was a problem hiding this comment.
Great job on the implementation! 🎉 While there are a couple of minor improvements suggested, they don't impact the core functionality. Keep up the good work and consider the feedback for future enhancements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __init__(self, name: str, weight: int, | ||
| coords: list[int] = None) -> None: | ||
| super().__init__(name, weight, coords) | ||
| self.coords = coords if coords is not None else [0, 0, 0] |
There was a problem hiding this comment.
In the FlyingRobot class, the initialization of self.coords should not be repeated after calling the super().init() method. The super class BaseRobot already initializes self.coords, so this line is unnecessary and could lead to confusion or errors.
| current_load: Cargo = None) -> None: | ||
| super().__init__(name, weight, coords) | ||
| self.max_load_weight = max_load_weight | ||
| self.current_load = current_load |
There was a problem hiding this comment.
In the DeliveryDrone class, when initializing self.current_load, it might be a good idea to check if the current_load's weight does not exceed max_load_weight. This would ensure that the drone does not start with an overloaded cargo.
No description provided.