Solution #1253
Open
Solution #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rabb1t-Artem
suggested changes
Oct 8, 2024
app/main.py
Outdated
| list[int] = None) -> None: | ||
| self.name = name | ||
| self.weight = weight | ||
| self.coords = coords if coords is not None else [0, 0] |
There was a problem hiding this comment.
its about "if coords is not None else"
app/main.py
Outdated
Comment on lines
36
to
40
| if coords is None: | ||
| coords = [0, 0, 0] | ||
| elif len(coords) == 2: | ||
| coords.append(0) | ||
| super().__init__(name, weight, coords) |
AnyoneClown
approved these changes
Oct 9, 2024
Comment on lines
+36
to
+39
| coords = coords or [0, 0, 0] | ||
| if len(coords) == 2: | ||
| coords.append(0) | ||
| super().__init__(name, weight, coords) |
There was a problem hiding this comment.
Suggested change
| coords = coords or [0, 0, 0] | |
| if len(coords) == 2: | |
| coords.append(0) | |
| super().__init__(name, weight, coords) | |
| super().__init__(name=name, weight=weight, coords=coords) | |
| self.coords = coords or [0, 0, 0] |
We can refactor it like this. When you pass coords to your father class with super() it will do the same logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.