Title #1211
Open
Title #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlopro
suggested changes
Sep 17, 2024
app/main.py
Outdated
| class FlyingRobot(BaseRobot): | ||
| def __init__(self, name: str, weight: int, coords: list = None) -> None: | ||
| coords = coords or [0, 0, 0] | ||
| super().__init__(name, weight, coords) |
There was a problem hiding this comment.
Instead coords = coords or [0, 0, 0], directly set coords=coords or [0, 0, 0] into init method
| coords: list = None | ||
| ) -> None: | ||
| coords = coords or [0, 0, 0] | ||
| super().__init__(name, weight, coords) |
LLkaia
suggested changes
Sep 17, 2024
app/main.py
Outdated
|
|
||
| class BaseRobot: | ||
| def __init__(self, name: str, weight: int, coords: list = None) -> None: | ||
| coords = coords or [0, 0] |
There was a problem hiding this comment.
Suggested change
| coords = coords or [0, 0] | |
| self.coords = coords or [0, 0] |
app/main.py
Outdated
| coords = coords or [0, 0] | ||
| self.name = name | ||
| self.weight = weight | ||
| self.coords = coords |
app/main.py
Outdated
Comment on lines
31
to
32
| self.coords = coords or [0, 0, 0] | ||
| super().__init__(name, weight, self.coords) |
There was a problem hiding this comment.
Suggested change
| self.coords = coords or [0, 0, 0] | |
| super().__init__(name, weight, self.coords) | |
| super().__init__(name, weight, coords or [0, 0, 0]) |
app/main.py
Outdated
Comment on lines
50
to
51
| self.coords = coords or [0, 0, 0] | ||
| super().__init__(name, weight, self.coords) |
There was a problem hiding this comment.
Suggested change
| self.coords = coords or [0, 0, 0] | |
| super().__init__(name, weight, self.coords) | |
| super().__init__(name, weight, coords) |
Since parent class will do the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.