Solution #1197
Open
Solution #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlopro
suggested changes
Sep 1, 2024
app/main.py
Outdated
| ) -> None: | ||
| super().__init__(weight) | ||
| self.name = name | ||
| if coords is None: |
There was a problem hiding this comment.
Simplify to
self.coords = coords or [0, 0]
app/main.py
Outdated
| weight: int, | ||
| coords: list = None | ||
| ) -> None: | ||
| super().__init__(name, weight, coords) |
There was a problem hiding this comment.
simplify to super().__init__(name, weight, coords or [0, 0, 0])
app/main.py
Outdated
| weight: int, | ||
| coords: list = None, | ||
| max_load_weight: int = 0, | ||
| current_load: int = None |
There was a problem hiding this comment.
Correct annotation for current_load
You should cover both Cargo and None in annotations for current_load
pavlopro
suggested changes
Sep 1, 2024
app/main.py
Outdated
| weight: int, | ||
| coords: list = None, | ||
| max_load_weight: int = 0, | ||
| current_load: int = None |
pavlopro
suggested changes
Sep 1, 2024
app/main.py
Outdated
| weight: int, | ||
| coords: list = None, | ||
| max_load_weight: int = 0, | ||
| current_load: int = None |
viktoria-rybenchuk
suggested changes
Sep 2, 2024
app/main.py
Outdated
Comment on lines
7
to
11
| def __init__(self, | ||
| name: str, | ||
| weight: int, | ||
| coords: list = None | ||
| ) -> None: |
There was a problem hiding this comment.
place each argument including self on a new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.