Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #585

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #585

wants to merge 3 commits into from

Conversation

AllaKuksa
Copy link

No description provided.


class CinemaBar:
@staticmethod
def sell_product(product: str, customer: Customer) -> Any:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def sell_product(product: str, customer: Customer) -> Any:
def sell_product(product: str, customer: Customer) -> None:

def movie_session(self,
movie_name: str,
customers: list[Customer],
cleaning_staff: Cleaner) -> Any:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cleaning_staff: Cleaner) -> Any:
cleaning_staff: Cleaner) -> None:

@AllaKuksa AllaKuksa requested a review from vsmutok July 14, 2023 05:22
Copy link
Contributor

@ArsenPidhoretskyi ArsenPidhoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this task no need to use Any as annotation. Fix in all places. Check what function returns

app/main.py Outdated
customers: list[dict],
hall_number: int,
cleaning_staff: str,
movie_name: str) -> Any:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function returns None, not Any

Copy link
Contributor

@ArsenPidhoretskyi ArsenPidhoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants