Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb5e38d
Solution
SerhiyNecha Oct 14, 2024
700028b
fix variables and remove example
SerhiyNecha Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added app/cinema/__init__.py
View file
Open in desktop
Empty file.
8 changes: 8 additions & 0 deletions app/cinema/bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from app.people.customer import Customer


class CinemaBar:

@staticmethod
def sell_product(product: str, customer: Customer) -> None:
print(f"Cinema bar sold {product} to {customer.name}.")
17 changes: 17 additions & 0 deletions app/cinema/hall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from app.people.cinema_staff import Cleaner
from app.people.customer import Customer


class CinemaHall:

def __init__(self, number: int) -> None:
self.number = number
Comment on lines +7 to +8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to add docstrings in your classes and methods. Even though your class and method names are descriptive, it's always a good idea to add a docstring explaining what the class or method does. This is especially useful for other developers who might use your code.


def movie_session(self, movie_name: str, customers: list[Customer],
cleaning_staff: Cleaner) -> None:
Comment on lines +10 to +11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using a list of Customer objects and a Cleaner object as parameters to the movie_session method. It would be a good idea to check if these parameters are of the expected types before using them. This will make your code more robust and prevent potential bugs.


print(f'"{movie_name}" started in hall number {self.number}.')
for customer in customers:
customer.watch_movie(movie_name)
print(f'"{movie_name}" ended.')
cleaning_staff.clean_hall(self.number)
Comment on lines +13 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using print statements for logging the start and end of the movie. This is fine for a small program, but in a larger application, it's better to use a logging framework. This will give you more control over the logging level, format, and destination. Additionally, it's a good idea to separate the logic of handling customers and cleaning staff. This will make your code more modular and easier to test and maintain.

24 changes: 20 additions & 4 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
# write your imports here
from app.cinema.bar import CinemaBar
from app.cinema.hall import CinemaHall
from app.people.cinema_staff import Cleaner
from app.people.customer import Customer


def cinema_visit(customers: list, hall_number: int, cleaner: str, movie: str):
# write you code here
pass
def cinema_visit(customers: list, hall_number: int,
cleaner_name: str, movie: str) -> None:

hall = CinemaHall(hall_number)
bar_func = CinemaBar()
cleaning = Cleaner(cleaner_name)
list_of_customer = []

for customer_info in customers:
customer = Customer(customer_info["name"], customer_info["food"])
list_of_customer.append(customer)
bar_func.sell_product(product=customer_info["food"], customer=customer)

CinemaHall.movie_session(self=hall, movie_name=movie,
customers=list_of_customer,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'self' parameter is not needed when calling a method on an instance. You should remove it.

cleaning_staff=cleaning)
Empty file added app/people/__init__.py
View file
Open in desktop
Empty file.
7 changes: 7 additions & 0 deletions app/people/cinema_staff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Cleaner:

def __init__(self, name: str) -> None:
self.name = name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to use type hinting for instance variables as well. In this case, you can add ': str' to 'self.name' for better readability and maintainability of the code. For example: 'self.name: str = name'.


def clean_hall(self, hall_number: int) -> None:
print(f"Cleaner {self.name} is cleaning hall number {hall_number}.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method 'clean_hall' currently prints a message to the console. While this is fine for testing, in a real-world application, you might want to consider logging this information instead of printing it. This would allow you to keep track of the cleaning activities in a more structured way.

8 changes: 8 additions & 0 deletions app/people/customer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
class Customer:

def __init__(self, name: str, food: str) -> None:
self.name = name
self.food = food

def watch_movie(self, movie: str) -> None:
print(f'{self.name} is watching "{movie}".')
Loading