Solution #958
Solution #958
Conversation
app/main.py
Outdated
app/cinema.sqlite
Outdated
app/managers.py
Outdated
|
|
||
| def create(self, first_name: str, last_name: str) -> None: | ||
| self._connection.execute( | ||
| f"INSERT INTO {self.table_name} VALUES (?, ?, ?) ", |
There was a problem hiding this comment.
Use parametrization, here you now clear which fields you need to insert
app/managers.py
Outdated
| f"UPDATE {self.table_name} " | ||
| f"SET first_name=?, last_name =? " | ||
| f"WHERE id=? ", |
app/managers.py
Outdated
| f"UPDATE {self.table_name} " | ||
| f"SET first_name=?, last_name =? " | ||
| f"WHERE id=? ", | ||
| (f_name, l_name, key) |
app/managers.py
Outdated
| ) | ||
| self._connection.commit() | ||
|
|
||
| def all(self) -> list: |
There was a problem hiding this comment.
This functio will return list of what? Fix annotation
app/managers.py
Outdated
| f"DELETE FROM {self.table_name} " | ||
| f"WHERE id=? ", |
app/managers.py
Outdated
| self._connection.execute( | ||
| f"DELETE FROM {self.table_name} " | ||
| f"WHERE id=? ", | ||
| (key,) |
app/main.py
Outdated
| @@ -11,3 +11,4 @@ | |||
| # print(Actor.objects.all()) | |||
| # Actor.objects.delete(1) | |||
There was a problem hiding this comment.
still not done - make sure this file look exactly like on master
app/managers.py
Outdated
| @@ -0,0 +1,44 @@ | |||
| import sqlite3 | |||
| from models import Actor | |||
There was a problem hiding this comment.
needs to be a blank line between different kinds of imports + we use full path from app
app/managers.py
Outdated
| def __init__(self) -> None: | ||
| self._connection = sqlite3.connect("./cinema.sqlite") | ||
| self.table_name = "actors" | ||
| self.db_name = "cinema.sqlite" |
There was a problem hiding this comment.
why do you create this attribute and never use it?
app/managers.py
Outdated
| def create(self, first_name: str, last_name: str) -> None: | ||
| self._connection.execute( | ||
| f""" | ||
| INSERT INTO {self.table_name} (first_name, last_name) VALUES (?, ?) |
There was a problem hiding this comment.
Check sql formatting - each key word must start from a new line. Use this tool to help you with styling https://sqlformat.org/
app/main.py
Outdated
| @@ -11,3 +11,4 @@ | |||
| # print(Actor.objects.all()) | |||
| # Actor.objects.delete(1) | |||
There was a problem hiding this comment.
still not done - make sure this file look exactly like on master
app/managers.py
Outdated
| f""" | ||
| INSERT INTO {self.table_name} (first_name, last_name) | ||
| VALUES (?, ?) | ||
| """, |
There was a problem hiding this comment.
would be nice to move it just 4 spaces to the left :)
Its work XD