Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #957

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# from models import Actor
# from managers import ActorManager
#
# if __name__ == "__main__":
# Actor.objects = ActorManager()
#
# Actor.objects.create(first_name="Emma", last_name="Watson")
# Actor.objects.create(first_name="Daniel", last_name="Radclife")
# print(Actor.objects.all())
# Actor.objects.update(2, "Daniel", "Radcliffe")
# print(Actor.objects.all())
# Actor.objects.delete(1)
# print(Actor.objects.all())
from app.models import Actor
from app.managers import ActorManager

if __name__ == "__main__":
Actor.objects = ActorManager()

Actor.objects.create(first_name="Emma", last_name="Watson")
Actor.objects.create(first_name="Daniel", last_name="Radclife")
print(Actor.objects.all())
Actor.objects.update(2, "Daniel", "Radcliffe")
print(Actor.objects.all())
Actor.objects.delete(1)
print(Actor.objects.all())
54 changes: 54 additions & 0 deletions app/managers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import sqlite3

from app.models import Actor


class ActorManager:
def __init__(self) -> None:
self.connection = sqlite3.connect("cinema.sqlite")
self.table_name = "actors"

def create(self, first_name: str, last_name: str) -> None:
self.connection.execute(
f"""
INSERT INTO {self.table_name} (first_name = ?, last_name = ?)
VALUES (?, ?)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use parametrization, as here you are sure which fileds you insert

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change this
first_name = ?, last_name = ?

""",
(first_name, last_name),
)
self.connection.commit()

def all(self) -> list[Actor]:
all_actors = self.connection.execute(
f"""
SELECT * FROM {self.table_name}
"""
)

return [Actor(*actor) for actor in all_actors]

def update(
self,
id_: int,
new_first_name: str,
new_last_name: str,
) -> None:
self.connection.execute(
f"""
UPDATE {self.table_name}
SET first_name = ?, last_name = ?
WHERE id = ?
""",
(new_first_name, new_last_name, id_),
)
self.connection.commit()

def delete(self, id_: int) -> None:
self.connection.execute(
f"""
DELETE FROM {self.table_name}
WHERE id = ?
""",
(id_,)
)
self.connection.commit()
8 changes: 8 additions & 0 deletions app/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from dataclasses import dataclass


@dataclass
class Actor:
id: int
first_name: str
last_name: str
Loading