-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commit #947
base: master
Are you sure you want to change the base?
First commit #947
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
# from models import Actor | ||
# from managers import ActorManager | ||
# | ||
# if __name__ == "__main__": | ||
# Actor.objects = ActorManager() | ||
# | ||
# Actor.objects.create(first_name="Emma", last_name="Watson") | ||
# Actor.objects.create(first_name="Daniel", last_name="Radclife") | ||
# print(Actor.objects.all()) | ||
# Actor.objects.update(2, "Daniel", "Radcliffe") | ||
# print(Actor.objects.all()) | ||
# Actor.objects.delete(1) | ||
# print(Actor.objects.all()) | ||
from models import Actor | ||
from managers import ActorManager | ||
|
||
if __name__ == "__main__": | ||
Actor.objects = ActorManager() | ||
|
||
Actor.objects.create(first_name="Emma", last_name="Watson") | ||
Actor.objects.create(first_name="Daniel", last_name="Radclife") | ||
print(Actor.objects.all()) | ||
Actor.objects.update(2, "Daniel", "Radcliffe") | ||
print(Actor.objects.all()) | ||
Actor.objects.delete(1) | ||
print(Actor.objects.all()) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import sqlite3 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be blank line between different types of imports - os and sqlite3 are build-in so they are the same type. only from app.models import Actor should be separated |
||
from models import Actor | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be blank line between imports |
||
|
||
|
||
class ActorManager: | ||
def __init__(self) -> None: | ||
self._connection = sqlite3.connect( | ||
"C:\\Users\\vlada\\py-actor-manager\\identifier.sqlite" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't hardcode path to db |
||
) | ||
self.table_name = "actors" | ||
|
||
def create(self, first_name: str, last_name: str) -> None: | ||
self._connection.execute( | ||
f"INSERT " | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is common to use triple quotes for multilne queries |
||
f"INTO {self.table_name} (first_name, last_name)" | ||
f"VALUES (?,?)", | ||
(first_name, last_name) | ||
) | ||
self._connection.commit() | ||
|
||
def all(self) -> None: | ||
actor_manager_cursor = self._connection.execute( | ||
f"SELECT * FROM {self.table_name}" | ||
) | ||
return [ | ||
Actor(*row) for row in actor_manager_cursor | ||
] | ||
|
||
def update( | ||
self, | ||
id_to_update: int, | ||
new_first_name: str, | ||
new_last_name: str | ||
) -> None: | ||
self._connection.execute( | ||
f"UPDATE {self.table_name} " | ||
f"SET first_name = ?, last_name = ? " | ||
f"WHERE id = ?", | ||
(new_first_name, new_last_name, id_to_update) | ||
) | ||
self._connection.commit() | ||
|
||
def delete(self, id_to_delete: int) -> None: | ||
self._connection.execute( | ||
f"DELETE FROM {self.table_name} " | ||
f"WHERE id = ?", | ||
(id_to_delete,) | ||
) | ||
self._connection.commit() | ||
|
||
|
||
if __name__ == "__main__": | ||
manager = ActorManager() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you don't need this here - code is being executed in main |
||
print(manager.all()) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
from dataclasses import dataclass | ||
|
||
|
||
@dataclass | ||
class Actor: | ||
id: int | ||
first_name: str | ||
last_name: str |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is no requirement to upload screenshot in this task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to push changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert all changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should look the same as on master 😿