Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #472

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #472

wants to merge 3 commits into from

Conversation

anna-lybid
Copy link

No description provided.

"first_name VARCHAR(50) NOT NULL, "
"last_name VARCHAR(50) NOT NULL"
")"
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we have to create the table from DB sql window.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ORENYT It wasn't mentioned

actors = self._connection.execute(
f"SELECT * FROM {self.table_name}"
)
return [Actor(*row) for row in actors]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to use unpacking

Copy link

@ORENYT ORENYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution

@anna-lybid anna-lybid closed this Sep 6, 2023
@anna-lybid anna-lybid deleted the develop branch September 6, 2023 12:02
@anna-lybid anna-lybid reopened this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants