Solution #462
Open
Solution #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serhii-Leonenko
suggested changes
Sep 7, 2023
app/cinema_db.db3
Outdated
app/managers.py
Outdated
|
|
||
| def all(self) -> List[Actor]: | ||
| actors_cursor = self._connection.execute( | ||
| f"SELECT * FROM {self.table_name}" |
There was a problem hiding this comment.
it's better to move FROM to the new line, increase readability
app/managers.py
Outdated
|
|
||
| def delete(self, id_to_delete: int) -> None: | ||
| self._connection.execute( | ||
| f"DELETE FROM {self.table_name} " f"WHERE id = ?", (id_to_delete,) |
app/managers.py
Outdated
Comment on lines
55
to
57
| if __name__ == "__main__": | ||
| manager = ActorManager() | ||
| print(manager.all()) |
app/managers.py
Outdated
Comment on lines
40
to
44
| self._connection.execute( | ||
| f"UPDATE {self.table_name} " | ||
| f"SET first_name = ?, last_name = ?" | ||
| f"WHERE id = ?", | ||
| (new_first_name, new_last_name, id_to_update), |
There was a problem hiding this comment.
I think you have syntax error here in SQL query
There was a problem hiding this comment.
@Serhii-Leonenko I don't see what's wrong here, can you explain ? :(
There was a problem hiding this comment.
Ok, maybe whitespace after last_name? :)
| @@ -40,7 +40,7 @@ def update( | |||
| ) -> None: | |||
| self._connection.execute( | |||
| f"UPDATE {self.table_name} " | |||
| f"SET first_name = ?, last_name = ?" | |||
| f"SET first_name = ?, last_name = ? " | |||
Serhii-Leonenko
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.