Solution actor manager #443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlejviki
suggested changes
Aug 3, 2023
app/managers.py
Outdated
|
|
||
| def all(self) -> None: | ||
| actors_cursor = self._connection.execute( | ||
| "SELECT id, first_name, last_name FROM actors" |
There was a problem hiding this comment.
You can use * to select all the columns from the table.
It is better to create an attribute to store the table name. By defining the table name as an attribute, you make the code more flexible and easier to update if the table name ever needs to be changed.
pavlejviki
suggested changes
Aug 8, 2023
| class ActorManager: | ||
| def __init__(self) -> None: | ||
| self._connection = sqlite3.connect("cinema.db3") | ||
|
|
There was a problem hiding this comment.
You haven't fixed the previous comment regarding the table name.
Create an attribute to store the table name and use it throughout your code.
Suggested change
| self.table_name = "actors" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.