Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #436

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #436

wants to merge 3 commits into from

Conversation

Psheiuk-Nazar
Copy link

No description provided.

Copy link

@Dimosphen1 Dimosphen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes were requested.

app/managers.py Outdated

def all(self) -> list:
actor_cursor = self.__connection.execute(
f"SELECT id, first_name, last_name FROM {self.table_name} ")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ) should be on a new line.

Copy link

@Polyakiv-Andrey Polyakiv-Andrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants