Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1718

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add task solution #1718

wants to merge 3 commits into from

Conversation

OlehHawryliuk
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 17, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-10-17 at 22 24 09
  • The menu should be scrollable in the landscape mode
  • Screenshot 2024-10-17 at 22 23 17
  • Screenshot 2024-10-17 at 22 23 21
  • Check styles here
  • Screenshot 2024-10-17 at 22 23 01
  • A user shouldn't be able to resize the text area
  • Screenshot 2024-10-17 at 22 22 44
  • Consider removing default outlines
  • Screenshot 2024-10-17 at 22 22 09
  • Check styles here
  • Screenshot 2024-10-17 at 22 21 52
  • There should be a tel link

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 17, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to deploy your fixes

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 17, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress here!

  • Screenshot 2024-10-17 at 23 24 55
  • Consider adding a favicon here
  • Screenshot 2024-10-17 at 23 24 47
  • Consider removing the page scroll under the menu
  • Screenshot 2024-10-17 at 23 23 37
  • Screenshot 2024-10-17 at 23 23 48
  • Check styles for the price

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 18, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider fixing previous comments

@OlehHawryliuk
Copy link
Author

Consider fixing previous comments

what else? i dont see anthing i haven`t fixed

anastasiiavorobiova
anastasiiavorobiova suggested changes Oct 18, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-18 at 15 37 15 Screenshot 2024-10-18 at 15 37 29 Screenshot 2024-10-18 at 15 37 54

@OlehHawryliuk
Copy link
Author

i am sorry it haven`t deployed succesfully, now you can check.

anastasiiavorobiova
anastasiiavorobiova approved these changes Oct 18, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlehHawryliuk @anastasiiavorobiova