solved task #909
solved task #909
Conversation
There was a problem hiding this comment.
Great job on implementing the classes and interfaces according to the checklist! 🌟 Remember to always return an empty list instead of null to avoid possible null pointer exceptions, and consider using local variables for better debugging and future code maintainability. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| public List<T> getAll(Class<? extends T> type) { | ||
| if (type == Bulldozer.class) { | ||
| return (List<T>) new BulldozerProducer().get(); | ||
| } else if (type == Excavator.class) { | ||
| return (List<T>) new ExcavatorProducer().get(); | ||
| } else if (type == Truck.class) { | ||
| return (List<T>) new TruckProducer().get(); | ||
| } | ||
| return new ArrayList<>(); |
There was a problem hiding this comment.
Consider creating a local variable in your implementation of getAll(Class type) method. Directly returning the result of new BulldozerProducer().get() is not recommended, as it does not allow for easy debugging or extension of the method's functionality. Instead, consider creating a local variable to hold the result before returning it.
| public class MachineServiceImpl<T extends Machine> implements MachineService<T> { | ||
| @Override | ||
| public List<T> getAll(Class<? extends T> type) { | ||
| if (type == Bulldozer.class) { | ||
| return (List<T>) new BulldozerProducer().get(); | ||
| } else if (type == Excavator.class) { | ||
| return (List<T>) new ExcavatorProducer().get(); | ||
| } else if (type == Truck.class) { | ||
| return (List<T>) new TruckProducer().get(); | ||
| } | ||
| return new ArrayList<>(); |
There was a problem hiding this comment.
Don't return null or specific type List in getAll() when no producer has been found. It's better to return an empty List to avoid potential null pointer exceptions and to provide a consistent API to the users of your method.
| public class MachineServiceImpl<T extends Machine> implements MachineService<T> { | ||
| @Override | ||
| public List<T> getAll(Class<? extends T> type) { | ||
| if (type == Bulldozer.class) { |
There was a problem hiding this comment.
Keep if else constructions simple. There is no need for else after return in the if clause. The code can be made more concise by removing the else keyword when it follows a return statement.
| public List<T> getAll(Class<? extends T> type) { | ||
| List<T> result = new ArrayList<>(); | ||
|
|
||
| if (type == Bulldozer.class) { |
There was a problem hiding this comment.
better use method equals (the same for other blocks)
| public class MachineServiceImpl<T extends Machine> implements MachineService<T> { | ||
| @Override | ||
| public List<T> getAll(Class<? extends T> type) { | ||
| List<T> result = new ArrayList<>(); |
There was a problem hiding this comment.
Create List<? extends Machine> result = new ArrayList<>(); and avoid casting
| trucks.add(new Truck()); | ||
| trucks.add(new Truck()); |
There was a problem hiding this comment.
better use loop for creating a list of objects (the same for other classes)
| } | ||
| if (type == Truck.class) { | ||
| List<Truck> trucks = new TruckProducer().get(); | ||
| result.addAll((List<T>) trucks); |
There was a problem hiding this comment.
you can avoid calling the getAll method by assigning the result of the get method to a variable result
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class MachineServiceImpl<T extends Machine> implements MachineService<T> { |
There was a problem hiding this comment.
| public class MachineServiceImpl<T extends Machine> implements MachineService<T> { | |
| public class MachineServiceImpl implements MachineService<Machine> { |
|
|
||
| public class MachineServiceImpl<T extends Machine> implements MachineService<T> { | ||
| @Override | ||
| public List<T> getAll(Class<? extends T> type) { |
There was a problem hiding this comment.
| public List<T> getAll(Class<? extends T> type) { | |
| public List<Machine> getAll(Class<? extends Machine> type) |
| } | ||
|
|
||
| @Override | ||
| public void fill(List<? super T> machines, T value) { |
There was a problem hiding this comment.
| public void fill(List<? super T> machines, T value) { | |
| public void fill(List<? super Machine> machines, Machine value) { |
| } | ||
|
|
||
| @Override | ||
| public void startWorking(List<? extends T> machines) { |
There was a problem hiding this comment.
| public void startWorking(List<? extends T> machines) { | |
| public void startWorking(List<? extends Machine> machines) { |
No description provided.