Created nessesery classes, changed Objects to PECS.

[Wersebu]

Created nessesery classes, changed Objects to PECS. All tests and builds passed

[mateacademy-ai-mentor]

Great job on implementing the classes according to the checklist requirements! 🌟 Remember to keep an eye on the small details like unnecessary empty lines and direct field access, as they can affect the overall quality and maintainability of your code. Keep up the good work, and always strive for clean and readable code! 💻👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

[mateacademy-ai-mentor]

Don't begin class or method implementation with empty lines. Remove the unnecessary empty lines between the package declaration and the class declaration.

[mateacademy-ai-mentor]

Don't forget about access modifiers for your custom fields in Bulldozer class. The field fuelConsuptionPerHour should be private and accessed through getters and setters.

[mateacademy-ai-mentor]

Don't forget about access modifiers for your custom fields in Excavator class. You should never want to expose the object fields directly. They should be accessed through special methods (getters and setters).

[mateacademy-ai-mentor]

According to the checklist, you should never want to expose the object fields directly. They should be accessed through special methods (getters and setters). Please add getter and setter methods for the maxCapacity field.

[mateacademy-ai-mentor]

Don't begin class or method implementation with an empty line.

[mateacademy-ai-mentor]

Consider creating a local variable in your implementation of getAll(Class type) method. It's good practice to create a local variable for the result list, which will be returned at the end of the method. This makes the code more readable and maintainable.

[mateacademy-ai-mentor]

Don't return null or specific type List in getAll() when no producer has been found. Instead of returning a new ArrayList<>(); directly, it's better to assign it to a local variable and return that variable. This ensures consistency and readability in the method's return points.

[mateacademy-ai-mentor]

There is no need to have a separate variable specifyMachines. You can directly assign the result of producer.get() to allMachines and return it, simplifying the code.

[mateacademy-ai-mentor]

The variable allMachines is unnecessary since you can return the new ArrayList<>(specifyMachines) directly. This will reduce the amount of code and improve readability.

[mateacademy-ai-mentor]

Don't begin class or method implementation with empty lines. There are unnecessary empty lines at the start of the class implementation.

[MateuszRostek]

You should add constructors to Machine class:

    public Machine() {

    }

    public Machine(String name, String color) {
        this.name = name;
        this.color = color;
    }

Then in classes that extends Machine you should leave one empty constructor and add another one that will look like this (of course adjusted to the relevant fields). For example in the Bulldozer:

public Bulldozer() {
    }
    
    public Bulldozer(String name, String color, Integer fuelConsuptionPerHour) {
        super(name, color);
        this.bladeWidth = bladeWidth;
        this.cabCapacity = cabCapacity;
    }

Then in all producers you should create objects using the second constructor (this one with all fields), For example:

    @Override
    public List<Excavator> get() {
        List<Excavator> excavator = new ArrayList<>();

        excavatorList.add(new Excavator("Exc 3000", "Blue", 60.0, 5.5));
        excavatorList.add(new Excavator("Exc 5000", "Yellow", 100.0, 8.5));
        excavatorList.add(new Excavator("Exc 800", "Yellow", 20.5, 2.5));

        return excavator;
    }

[MateuszRostek]

Good job! See one minor advice and implement it!

[MateuszRostek]

Do not use over-complicated if-else constuction, bette to use switch here, for example:

    @Override
    public List<Machine> getAll(Class<? extends Machine> type) {
        List<? extends Machine> machines;
        switch (type.getSimpleName()) {
            case "Bulldozer" -> machines = new BulldozerProducerImpl().get();
            case "Excavator" -> machines = new ExcavatorProducerImpl().get();
            case "Truck" -> machines = new TruckProducerImpl().get();
            default -> {
                return Collections.emptyList();
            }
        }
        return new ArrayList<>(machines);
    }