Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let`s see #2183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer is working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in the doWork method is informative and correctly indicates the type of Machine that is working.

}

@Override
public void stopWork() {
System.out.println("Bulldozer has stopped working");
}
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator is working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in the doWork method should be more informative by indicating the type of Machine that is working, such as 'Excavator is starting to work'.

}

@Override
public void stopWork() {
System.out.println("Excavator has stopped working");
}

}
7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package core.basesyntax;

public abstract class Machine {
public abstract void doWork();
public abstract void stopWork();

}
11 changes: 10 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
package core.basesyntax;

public class MainApp {

public static void main(String[] args) {
Machine excavator = new Excavator();
Machine truck = new Truck();
Bulldozer bulldozer = new Bulldozer();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use an abstract reference for the bulldozer variable as well. According to the checklist: 'Use abstract references instead of specific ones where possible.' Change Bulldozer bulldozer = new Bulldozer(); to Machine bulldozer = new Bulldozer();.

Machine[] machines = {excavator, truck, bulldozer};
for (Machine m : machines) {
m.doWork();
m.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck is working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate what type of Machine is working right now. Consider making the message more informative, such as 'Truck is starting to work'.

}

@Override
public void stopWork() {
System.out.println("Truck has stopped working");
}
}
Loading