-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created class Machine #2156
Created class Machine #2156
Changes from 2 commits
c70ff2b
5d7ff28
28393cc
0015a74
bff30d9
a205c81
657f3fc
55822b7
40a42b8
2260b17
f074813
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package core.basesyntax; | ||
|
||
public class Bulldozer extends Machine { | ||
|
||
public void doWork() { | ||
System.out.println("Bulldozer started its work."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message should indicate what type of |
||
} | ||
|
||
public void stopWork() { | ||
System.out.println("Bulldozer has stopped working."); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package core.basesyntax; | ||
|
||
public class Excavator extends Machine { | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
public void doWork() { | ||
System.out.println("Excavator started its work."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message in 'doWork' method should be more informative. It should indicate that it is an Excavator that has started working. Consider including the type of machine in the message. |
||
} | ||
|
||
public void stopWork() { | ||
System.out.println("Excavator has stopped working."); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,8 @@ | ||||||
package core.basesyntax; | ||||||
|
||||||
abstract class Machine { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the checklist, class elements should have appropriate access modifiers. Consider if the abstract class There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||||||
public abstract void doWork(); | ||||||
|
||||||
public abstract void stopWork(); | ||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,16 @@ | ||
package core.basesyntax; | ||
|
||
public class MainApp { | ||
public static void main(String[] args) { | ||
Machine[] machines = { | ||
new Truck(), | ||
new Bulldozer(), | ||
new Excavator(), | ||
}; | ||
|
||
for (Machine machine: machines) { | ||
machine.doWork(); | ||
machine.stopWork(); | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||
package core.basesyntax; | ||||||
|
||||||
class Truck extends Machine { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The class There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
@Override | ||||||
public void doWork() { | ||||||
System.out.println("Truck started its work."); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message in |
||||||
} | ||||||
|
||||||
public void stopWork() { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||||||
System.out.println("Truck has stopped working."); | ||||||
} | ||||||
} | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add redundant empty lines to your code.