Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created class Machine #2156

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Bulldozer extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public void doWork() {
System.out.println("Bulldozer started its work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate what type of Machine is working right now. Consider including the class name in the message for clarity, e.g., 'Bulldozer is working.'

}

public void stopWork() {
System.out.println("Bulldozer has stopped working.");
}
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Excavator extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

public void doWork() {
System.out.println("Excavator started its work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in 'doWork' method should be more informative. It should indicate that it is an Excavator that has started working. Consider including the type of machine in the message.

}

public void stopWork() {
System.out.println("Excavator has stopped working.");
}
}
8 changes: 8 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package core.basesyntax;

abstract class Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the checklist, class elements should have appropriate access modifiers. Consider if the abstract class Machine should be public to be accessible by other classes in different packages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
abstract class Machine {
public abstract class Machine {


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

public abstract void doWork();

public abstract void stopWork();
}
11 changes: 11 additions & 0 deletions src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
package core.basesyntax;

public class MainApp {
public static void main(String[] args) {
Machine[] machines = {
new Truck(),
new Bulldozer(),
new Excavator(),
};

for (Machine machine: machines) {
machine.doWork();
machine.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

class Truck extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class Truck should be declared as public to match the visibility of its superclass Machine and to be accessible from other packages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Truck extends Machine {
public class Truck extends Machine {

@Override
public void doWork() {
System.out.println("Truck started its work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in doWork method is not informative enough. It should indicate that the 'Truck' is the type of Machine that is working now. For example: "Truck is doing its work."

}

public void stopWork() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stopWork method should be annotated with @Override to clearly indicate that it is overriding a method from the superclass Machine.

System.out.println("Truck has stopped working.");
}
}

Loading