add machines #2127
add machines #2127
Conversation
There was a problem hiding this comment.
Great job on implementing the Excavator class and correctly overriding the doWork and stopWork methods! 🌟 Your use of abstraction in the Machine class is spot on. Just remember for future updates, more informative messages can be very helpful for clarity. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Stop start working!"); |
There was a problem hiding this comment.
The message in the stopWork method is not informative about the type of Machine that stopped working. According to the checklist, it should indicate the specific type of machine, in this case, Bulldozer. Consider changing the message to something like 'Bulldozer stopped working!' to make it clear and informative.
| public class Excavator extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator start working!"); |
There was a problem hiding this comment.
Consider making the start message more informative. For example: 'Excavator has begun its work.' This follows the checklist item of writing informative messages in methods.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator stop working!"); |
There was a problem hiding this comment.
Consider making the stop message more informative as well. For instance: 'Excavator has completed its work and is stopping.' This aligns with the checklist requirement for informative messages.
| Truck truck = new Truck(); | ||
| Excavator excavator = new Excavator(); | ||
| Bulldozer bulldozer = new Bulldozer(); |
There was a problem hiding this comment.
According to the checklist, it is recommended to use abstract references instead of specific ones to take advantage of polymorphism. Instead of creating Truck, Excavator, and Bulldozer as specific types, you should declare them as Machine type. This allows for more flexible code if you decide to add more functionality that works with different Machine types.
| public class Truck extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck start working!"); |
There was a problem hiding this comment.
The message 'Truck start working!' should be more informative and indicate that it is a Truck that is working. Consider rephrasing it to include the type of machine, for example: 'Truck is now working.'
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck stop working!"); |
There was a problem hiding this comment.
Similarly, the stop message should be more informative. You could change it to 'Truck has stopped working.' to clearly indicate the machine type and its current state.
| Truck truck = new Truck(); | ||
| Excavator excavator = new Excavator(); | ||
| Bulldozer bulldozer = new Bulldozer(); |
There was a problem hiding this comment.
| Truck truck = new Truck(); | |
| Excavator excavator = new Excavator(); | |
| Bulldozer bulldozer = new Bulldozer(); | |
| Machine truck = new Truck(); | |
| Machine excavator = new Excavator(); | |
| Machine bulldozer = new Bulldozer(); |
No description provided.