Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created classes, overridden abstract methods, and created an array of… #2119

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

created classes, overridden abstract methods, and created an array of… #2119

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47e3b25
created classes, overridden abstract methods, and created an array of…
FireFalcons Aug 22, 2024
11ab46d
added fixed after review
FireFalcons Aug 22, 2024
b0bae41
fixed the mistakes after rewatching
FireFalcons Aug 22, 2024
29109a8
fixed errors in in MainApp and Machine classes
FireFalcons Aug 22, 2024
bde023b
shortened the code in MainApp class
FireFalcons Aug 22, 2024
77d4451
fixes style
FireFalcons Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package core.basesyntax;
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer started it's work");
}

@Override
public void stopWork() {
System.out.println("Bulldozer stopped it's work");
}
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package core.basesyntax;
package core.basesyntax;

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator started it's work");
}

@Override
public void stopWork() {
System.out.println("Excavator stopped it's work");
}
}
5 changes: 5 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package core.basesyntax;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package core.basesyntax;
package core.basesyntax;

public abstract class Machine {
public abstract void doWork();
public abstract void stopWork();
}
13 changes: 12 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
package core.basesyntax;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert empty line

public class MainApp {
public static void main(String[] args) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Machine truck = new Truck();
Machine bulldozer = new Bulldozer();
Machine excavator = new Excavator();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use abstract references instead of specific ones where possible. This allows for more flexible code that can take advantage of polymorphism. For example, consider using 'Vehicle truck = new Truck();' if 'Vehicle' is an appropriate abstract class or interface in your codebase.

Machine[] machines = {truck, bulldozer, excavator};

for (Machine m : machines) {
m.doWork();
m.stopWork();
System.out.println();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant empty line after the method call. According to the checklist, please don't add redundant empty lines to your code. It's better to remove this line to make the code cleaner.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (Machine m : machines) {
m.doWork();
m.stopWork();
System.out.println();
for (Machine machine : machines) {
machine.doWork();
machine.stopWork();

}
}
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package core.basesyntax;
package core.basesyntax;

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck started it's work");
}

@Override
public void stopWork() {
System.out.println("Truck stopped it's work");
}
}
Loading