Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top m #2031

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Top m #2031

wants to merge 12 commits into from

Conversation

Hot00Tea
Copy link

@Hot00Tea Hot00Tea commented Jun 5, 2024

No description provided.

Copy link

@MentorMateAcademy MentorMateAcademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
At first fix checks, before sending task use command
mvn clean package

Copy link

@MentorMateAcademy MentorMateAcademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your task not finished

@Hot00Tea
Copy link
Author

Hot00Tea commented Jun 5, 2024

Screenshot_1

В мене помилка яку я не знаю як виправити

@Hot00Tea
Copy link
Author

Я здав чи треба переробити щось?

@Hot00Tea
Copy link
Author

Done

Comment on lines 6 to 14
public void doWork() {

}

@Override
public void stopWork() {

}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add implementation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не розумію як

src/main/java/core/basesyntax/Truck.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/MainApp.java Outdated Show resolved Hide resolved
Copy link
Contributor

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add realization to your solution ;)


@Override
public void doWork() {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the realization to all override methods in classes that extend Machine
for example:

Suggested change
System.out.println("Bulldozer started working!");


@Override
public void stopWork() {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add realization

public class Excavator extends Machine {

@Override

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant empty line

Suggested change


abstract void stopWork();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant empty line

Suggested change

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant empty line

Comment on lines 7 to 13
public void doWork() {
}

@Override
public void stopWork() {
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add realization

Comment on lines 5 to 11
@Override
public void doWork() {
}

@Override
public void stopWork() {
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add realization

@Override
public void stopWork() {
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant empty line

package core.basesyntax;

public class Bulldozer extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some questions about this comment? Please don't add redundant empty lines to your code.

package core.basesyntax;

public class Excavator extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

package core.basesyntax;

public abstract class Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

@@ -2,4 +2,12 @@

public class MainApp {

private Machine[] machines = {new Excavator(), new Truck(), new Bulldozer()};

public void main() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void main() {
public static void main(String[] args) {

@@ -2,4 +2,12 @@

public class MainApp {

private Machine[] machines = {new Excavator(), new Truck(), new Bulldozer()};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace to main method

package core.basesyntax;

public class Truck extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package core.basesyntax;

public class Bulldozer extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some questions about this comment? Please don't add redundant empty lines to your code.

package core.basesyntax;

public class Bulldozer extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 4 line

@Override
public void doWork() {
System.out.println("Bulldozer started working!");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 8 line

package core.basesyntax;

public class Excavator extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 4 line

package core.basesyntax;

public class Truck extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 4 line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants