Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created class Machine #1594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anigilator479
Copy link

@anigilator479 anigilator479 commented Aug 9, 2023

Created class Machine
Created classes inheriters Truck, Bulldozer, Excavator
Override doWork(), stopWork()
Created Machine array

Created classes inheriters Truck, Bulldozer, Excavator
Override doWork(), stopWork()
Created Machine array
Copy link
Contributor

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Let’s fix minor mistakes;)


public abstract void stopWork();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant empty line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn causes an error if i remove this empty line

@@ -1,5 +1,11 @@
package core.basesyntax;

public class MainApp {

public static void machineWork() {
Machine[] machines = new Machine[]{new Excavator(),new Bulldozer(),new Truck()};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Machine[] machines = new Machine[]{new Excavator(),new Bulldozer(),new Truck()};
Machine[] machines = new Machine[]{new Excavator(), new Bulldozer(), new Truck()};

Let’s use white spaces ;)

};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this class? Let’s revert these changes

Copy link
Contributor

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants