Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java OOP basic solution #1584

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

YuraNR
Copy link

@YuraNR YuraNR commented Aug 7, 2023

No description provided.

Copy link
Author

@YuraNR YuraNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed solution

Copy link
Contributor

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Let’s fix a few minor mistakes 😉

@@ -1,5 +1,18 @@
package core.basesyntax;

public class MainApp {
public static void main(String[] args) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant empty line

Comment on lines 9 to 14
for (Machine machine : machines) {
machine.doWork();
}
for (Machine machine : machines) {
machine.stopWork();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you combine these loops?

for (Machine machine : machines) {
machine.stopWork();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant empty line

Copy link
Author

@YuraNR YuraNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make changes

Copy link
Contributor

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s fix all previous comments ;)

@YuraNR
Copy link
Author

YuraNR commented Aug 9, 2023

Let’s fix all previous comments ;)

I have make all changes, with new commit java OOP basic solution.2 . I make one loop, and deleted empty lines. You see my previous code or new?

Copy link
Contributor

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything looks perfect :liliia-satisfied:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants