add task solution #1533
Open
add task solution #1533
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Great job on the pull request! 🎉 While there are a couple of minor issues, like the use of replaceAll and a missing semicolon, they don't critically impact the functionality. Keep up the good work and consider these suggestions for future improvements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| let total = 0; | ||
|
|
||
| const setting = population |
There was a problem hiding this comment.
There is a missing semicolon at the end of this line. It's important to maintain consistency in your code style.
| return el.textContent; | ||
| }) | ||
| .map((el) => { | ||
| return el.replaceAll(',', ''); |
There was a problem hiding this comment.
The method replaceAll is not supported in all browsers. Consider using a more compatible method like replace with a global regular expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rekverrwith your Github username in the linknpm run lintcommand instead ofnpm test