add solution #1531
Open
add solution #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myuriy81
commented
Oct 17, 2024
myuriy81
commented
- DEMO LINK
mateacademy-ai-mentor
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Great job on the pull request! 🎉 The issues mentioned are minor and don't critically impact the functionality. Just keep an eye on compatibility and potential edge cases in the future. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| let totalPopulation = 0; | ||
|
|
||
| populationArray.forEach((item) => { | ||
| const population = +item.textContent.replaceAll(',', ''); |
There was a problem hiding this comment.
The use of replaceAll might not be supported in all environments. Consider using replace with a global regular expression if compatibility is a concern.
| totalPopulationElement.textContent = totalPopulation.toLocaleString('en-US'); | ||
|
|
||
| averagePopulationElement.textContent = ( | ||
| totalPopulation / populationArray.length |
There was a problem hiding this comment.
Ensure that populationArray.length is not zero to avoid division by zero errors. Consider adding a check before performing the division.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.