Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1449

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Solution #1449

wants to merge 5 commits into from

Conversation

vikaruda
Copy link

@vikaruda vikaruda commented Sep 5, 2024

No description provided.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo link, also, you need to fix the failed tests, if you need help feel free in the fe_chat
image

@vikaruda
Copy link
Author

vikaruda commented Sep 5, 2024

DEMO LINK

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and provide the demo link to your project

Comment on lines 10 to 20
// eslint-disable-next-line no-unused-vars
let value = allElementSpan[i].textContent;

// eslint-disable-next-line no-undef
if (!isNaN(value)) {
// eslint-disable-next-line no-unused-expressions, no-undef
value = +value;

// eslint-disable-next-line no-undef
totalValue += value;
count++;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need all those eslint disable lines

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but tests is still failed. Please feel free to ask for help in fe_chat.

Comment on lines 35 to 38
console.log('Total Value: ', formattedTotal);


console.log('Avarage Value: ', formattedAvarage);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image numbers should be there, pls ask for some help with this task in the chat

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants