add task solution #1424
Open
add task solution #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Aug 19, 2024
src/scripts/main.js
Outdated
Comment on lines
10
to
14
| ArrayOfSelectorPopulation.forEach((selector) => { | ||
| const NUMBER = Number(selector.textContent.replaceAll(',', '')); | ||
|
|
||
| newTotal += NUMBER; | ||
| }); |
There was a problem hiding this comment.
looks like you can simplify it using the reduce method
src/scripts/main.js
Outdated
| @@ -1,3 +1,20 @@ | |||
| 'use strict'; | |||
|
|
|||
| // write your code here | |||
| const ArrayOfSelectorPopulation = [...document.querySelectorAll('.population')]; | |||
There was a problem hiding this comment.
Suggested change
| const ArrayOfSelectorPopulation = [...document.querySelectorAll('.population')]; | |
| const arrayOfSelectorPopulation = [...document.querySelectorAll('.population')]; |
name vars and functions in camelCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate average and total numbers and it must be separated by a thousands separator.