Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading peak_comments in json reader #437

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

zargham-ahmad
Copy link
Collaborator

This PR includes the following:

closes #415

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

1 similar comment
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hechth
Copy link
Collaborator

hechth commented Jun 15, 2023

Looks good - @xtrojak this should fix the initial issue, right?

@xtrojak
Copy link

xtrojak commented Jun 15, 2023

Looks good - @xtrojak this should fix the initial issue, right?

@hechth yes, with this we can implement support for JSON RECETOX/galaxytools#355

@hechth hechth merged commit 942b63b into matchms:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading JSON with peak_comments
3 participants