This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Improve and document the configuration #228
Open
feeds
wants to merge
4
commits into
staging
Choose a base branch
from
config-doc
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrne
reviewed
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, will test locally when complete. I like the separation of the apps :)
if B.profile_visible_for_participants_of_different_type: | ||
if settings.PARTICIPANT_SETTINGS[ | ||
"B" | ||
].profile_visible_for_participants_of_different_type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very ugly formatting 🙈
I know its not your fault, it just looks awful.
|
||
* ``name`` - the name with which this participant group should be referred to on the website itself | ||
|
||
* ``properties`` - the list of properties that the participant type should be able to set on signup. The available properties are documented below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A hyperlink could be useful in the finished PR
Suggested change
* ``properties`` - the list of properties that the participant type should be able to set on signup. The available properties are documented below. | |
* ``properties`` - the list of properties that the participant type should be able to set on signup. The available properties are documented below_. | |
.. _below: :ref:`configuration:properties` |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement of the configuration documentation (baby steps :))
Also, our app should not directly import "match4everything" for compatibility reasons, so we import the configuration from
django.conf
now